Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor frontend #12

Merged
merged 45 commits into from
Nov 27, 2024
Merged

Refactor frontend #12

merged 45 commits into from
Nov 27, 2024

Conversation

NanamiNakano
Copy link
Collaborator

@NanamiNakano NanamiNakano commented Nov 23, 2024 •
edited
Loading

Description

This PR refactors frontend, fixes infinite re-render issues, and brings some performance enhancements by reducing unnecessary re-rendering and useEffect hooks.

Details

Optimizations

  • Now the data used for initialization (labels, user data and "task" length) will now only be loaded once
  • Add error handling
  • Add load state
  • Reduce unnecessary calculations between re-renders with useMemo and useCallback
  • Simplified rendering logic

Project structure

  • Separate util functions from components
  • State Management with zustand
  • Split components for easier maintenance

Bug fixes

  • Fix column resize styling issue by rewriting the history table
  • Fix highlighting components (SliceText and JustSliceText, perviously defined inside the Page component) infinite re-render issue
  • Fix the issue that sometimes it was not possible to manually select texts when server section rendered

Modifications

  • Disable selection when viewing history (Editing will be implemented in the future)

Testing

@Yazawazi and I have tested that all the features work correctly!

@NanamiNakano
feat: Seperated user database
2a8af94 
Add scripts for migration and management
@NanamiNakano
feat(database): auth_user
f2ba6d1
@NanamiNakano
feat: Authentication
9d15e35
@NanamiNakano
feat: Change authentication method to access_token
47d7ee2
@NanamiNakano
feat(frontend)!: simple login
b9dcbf4
@NanamiNakano
docs(README): Add instructions for migration, update technical details
0564ea6
@NanamiNakano
fix(backend): Fix type error
04a192c
@NanamiNakano
fix(frontend): Add error handling
3a19584
@NanamiNakano
refactor!: migrator.py
29a7e45 
modularize migrator.py
allow users to specify new email and password for each migrated user with a csv file
store the random password set in a csv file
@NanamiNakano
docs(README): Update technical details
e34303e 
Add information about the creation of users.
Update information about the `users` table.
Add information about JWT secret.
@NanamiNakano
feat(backend): Add update annotation endpoint
89430b3
@NanamiNakano
refactor(frontend): Separate UserPopover component
2bb0db9
@NanamiNakano
refactor(frontend):
db168e4 
Separate LabelPagination component
@NanamiNakano
refactor(frontend): Separate ExistingPane component
94d90ea
@NanamiNakano
refactor(component): Rewrite ExistingPane component
0f885d7
@NanamiNakano
chore(lint): Lint
e2601ca
@NanamiNakano
fix(bug): Can not load summary slice
0193e49
@NanamiNakano
Merge branch 'sqlite' into feature-edit-annotation
af1aec4
@NanamiNakano
chore: Remove redundant code
441a464
@NanamiNakano
refactor(frontend): Rewrite indexStore data fetching logic
1edec27
@NanamiNakano
refactor(frontend): Reduce useEffect usage to prevent unnecessary re-…
69c6d5e 
…render
@NanamiNakano
refactor(frontend): Rewrite initialization logic
2fa0608
@NanamiNakano
chore(frontend): Use immer to improve codes
cd4f7c2
@NanamiNakano
chore(frontend): Rename store types
818e184
@NanamiNakano
docs: Update documentation for user_utils.py
04d3d2d
@NanamiNakano
Revert "feat(backend): Add update annotation endpoint"
ed55a24 
This reverts commit 89430b3.
@NanamiNakano
refactor(frontend): error handling and loading state
6fa4ce9
@NanamiNakano
chore: Remove redundant code
ef0af1a
@NanamiNakano
refactor: Rewrite index page's basic features
4d564ee
@NanamiNakano
style(fallback): Update Loading component's style
8d75592
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 6.36 kB types
npm/[email protected] environment 0 627 kB mweststrate
npm/[email protected] None 0 344 kB timdown
npm/[email protected] environment +2 149 kB daishi
npm/[email protected] environment +2 114 kB react-bot
npm/[email protected] None 0 88.5 kB daishi
pypi/[email protected] environment Transitive: eval, filesystem, network, shell, unsafe +180 1.46 GB hynek
pypi/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +223 1.5 GB

View full report↗︎

@NanamiNakano NanamiNakano marked this pull request as ready for review November 23, 2024 15:39
@NanamiNakano
Copy link
Collaborator Author

#10 should be merge first

@forrestbao forrestbao merged commit ca2a611 into TexteaInc:sqlite Nov 27, 2024
3 checks passed
@NanamiNakano NanamiNakano deleted the refactor/frontend branch November 27, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yazawazi Yazawazi Awaiting requested review from Yazawazi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NanamiNakano @forrestbao